feat: The function implementation of tree component#1108
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the tree component by introducing a React Query hook for fetching tree data and renaming the breadcrumb component for consistency across pages.
- Renamed the breadcrumb component and updated its imports/usage in tree and blob pages
- Added
useGetTreehook to fetch repository tree data - Renamed component inside BreadCrumb.tsx from
BreadtoBreadcrumb
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| moon/apps/web/pages/[org]/code/tree/[...path]/index.tsx | Updated import/use of breadcrumb component |
| moon/apps/web/pages/[org]/code/blob/[...path].tsx | Updated import/use of breadcrumb component |
| moon/apps/web/hooks/useGetTree.ts | Added useGetTree React Query hook |
| moon/apps/web/components/CodeView/TreeView/BreadCrumb.tsx | Renamed component from Bread to Breadcrumb |
Comments suppressed due to low confidence (2)
moon/apps/web/components/CodeView/TreeView/BreadCrumb.tsx:8
- [nitpick] The file name 'BreadCrumb.tsx' and component name 'Breadcrumb' diverge in casing. Consider renaming the file to 'Breadcrumb.tsx' or renaming the component to 'BreadCrumb' for consistency.
const Breadcrumb = ({ path }:any) => {
moon/apps/web/hooks/useGetTree.ts:5
- The new
useGetTreehook isn’t covered by any tests. Consider adding unit or integration tests to validate its loading, success, and error behaviors.
export function useGetTree(params: GetApiTreeParams, requestParams?: RequestParams) {
| import { UrlObject } from 'url'; | ||
|
|
||
| const Bread = ({ path }:any) => { | ||
| const Breadcrumb = ({ path }:any) => { |
There was a problem hiding this comment.
Avoid using any for the path prop. Define a precise type (e.g., string[] or a specific path object) to improve type safety and maintainability.
benjamin-747
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.